Add support for generic Hashers #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
===========================================
- Coverage 100.00% 97.83% -2.17%
===========================================
Files 3 2 -1
Lines 315 323 +8
===========================================
+ Hits 315 316 +1
- Misses 0 7 +7 ☔ View full report in Codecov by Sentry. |
|
Hello, thanks for your contribution. I never implemented this functionality since I never needed it but if it helps you I would be glad to add it. When I read through the code I thought, why not also add it to the |
|
Thanks. And as far as I understand it, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Firstly, thank you, I am using this crate in my hobby project and it's been very handy so far.
However, I ran into a few minor issues, the most noticeable being missing support for other Hashers (FxHasher in my case). So if you don't mind, I made this PR (and possibly will make more for the rest).
I tried following the
std'sHashMapimplementation as closely as possible and based on both the docstring test and my project, it seems to work great.